Variations of this bill have been floating around for ~20 years. I don’t know if this particular one is the “final” one NRA would like to move through Congress. They have issued a supporting statement for it.
It doesn’t have to be a perfect bill. Something that basically says people from outside the state can carry in New York may open up new legal challenges to the Sullivan Act. Ex. Why could a Pennsylvania resident carry in New York City, but me as a state resident, could not?
Also, non-residents should not take reciprocity as an invitation to carry in the state. I can see the NYPD arresting people in spite of such a law as has been done before with travelers passing through the airports who were protected under FOPA. This is just a good next step for us.